Re: [Xen-devel] [PATCH] [v3] libxc: Replace alloca() with mmap() for array sizes greater than a page in xc_linux_osdep.c

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH] [v3] libxc: Replace alloca() with 
mmap() for array sizes greater than a page in xc_linux_osdep.c"):
> On Mon, 2012-04-23 at 23:21 +0100, Aravindh Puthiyaparambil wrote:
> > When mapping in large amounts of pages (in the GB range) from a guest in to 
> > Dom0 using xc_map_foreign_bulk(), a segfault occurs in the libxc client 
> > application. This is because the pfn array in 
> > linux_privcmd_map_foreign_bulk() is being allocated using alloca() and the 
> > subsequent memcpy causes the stack to blow. This patch replaces the 
> > alloca() with mmap() for pfn array sizes greater than a page.
> > 
> > Fix an error print with the correct function name.
> > 
> > Do the same for the map array in linux_gnttab_grant_map()
> > 
> > Signed-off-by: Aravindh Puthiyaparambil <aravindh@xxxxxxxxxxxx>
> > Acked-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,

Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel