[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xen/p2m: m2p_find_override: use list_for_each_entry_safe

On Fri, 20 Apr 2012, Dan Carpenter wrote:
> Hi Stefano,
> I had a question about 8f2854c74ff4: "xen/p2m: m2p_find_override: use
> list_for_each_entry_safe".
> I think there is a misunderstanding about what the
> list_for_each_entry_safe() macro does.  It has nothing to do with
> locking, so the spinlock is still needed.  Without the lock ->next could
> point to an element which has been deleted in another thread.  Probably
> the patch should be reverted.

I thought that list_for_each_entry_safe is safe against deletion, is it
It doesn't matter whether we get up to date entries or old entries
here as long as walking through the list doesn't break if a concurrent
thread adds or removes items.

> Also, it introduces a GCC warning:
> arch/x86/xen/p2m.c:811:16: warning: unused variable âflagsâ
>       [-Wunused-variable]

I think that Konrad didn't submit the latest version of the patch (v3),
that has a better description and also removes the flags variable:
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.