[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xen/p2m: m2p_find_override: use list_for_each_entry_safe

Hi Stefano,

I had a question about 8f2854c74ff4: "xen/p2m: m2p_find_override: use

I think there is a misunderstanding about what the
list_for_each_entry_safe() macro does.  It has nothing to do with
locking, so the spinlock is still needed.  Without the lock ->next could
point to an element which has been deleted in another thread.  Probably
the patch should be reverted.

Also, it introduces a GCC warning:
arch/x86/xen/p2m.c:811:16: warning: unused variable âflagsâ

dan carpenter

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.