[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] bogus BUG_ON() in 2.6.18's pci_enable_msix()



Haitao,

in c/s 680:583086d5cd26 you added

        BUG_ON(entries[i].vector != evtchn_get_xen_pirq(irq));

to said function, which seems wrong to me for two reasons: For one,
.vector (as output) always holds Linux IRQ numbers, not Xen ones.
And then this field can't be expected to be set on entry at all, hence
expecting *any* particular value seems incorrect.

Thanks for your thoughts,
Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.