Re: [Xen-devel] [PATCH] tools/vtpm: do not install if vtpm can not be build

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[Xen-devel] [PATCH] tools/vtpm: do not install if vtpm can 
not be build"):
> tools/vtpm: do not install if vtpm can not be build
> 
> A simple 'make tools' fails in vtpm because there is also a 'make install'
> during make tools. vtpm checks only in the build target wether it can be
> built at all, but the check is missing in the install target as well.

Thanks.  I have two comments: firstly, I think it would be best to
avoid repeating the test in the install rule.  If necessary you can
use a make variable to contain the runes.

But my second comment is: shouldn't this kind of test be done with
autoconf nowadays ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel