Re: [Xen-devel] [PATCH] tools/vtpm: use LDLIBS to pass -lgmp

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Apr 03, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH] tools/vtpm: use LDLIBS to pass 
> -lgmp"):
> > tools/vtpm: use LDLIBS to pass -lgmp
> > 
> > Linking tpmd will fail with recent toolchains because -lgmp is passed
> > via LDFLAGS instead of LDLIBS. With this change -lgpm is placed at the
> > end of the gcc cmdline and linking tpmd succeeds again.
> ...
> >   CFLAGS  += $(WFLAGS) -g -I.. -I. -O2 -fno-strict-aliasing
> >  +CFLAGS  += -I../../../../tools/vtpm_manager/manager
> > - LDFLAGS += -lgmp
> > + LDLIBS  += -lgmp
> >   
> >  -BINDIR  := /usr/sbin/
> >  +BINDIR  := /usr/bin/
> 
> Please could you make sure not to include unrelated changes in your
> patches.  That makes the job of the reviewer /much/ harder, because we
> would have to inspect every hunk of your patches looking for this kind
> of thing creeping in.

This patch changes a patch file for vtpm which has LDFLAGS in the
context around the changed lines.
See the space between the '-' and LDFLAGS.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel