[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/vtpm: use LDLIBS to pass -lgmp

Olaf Hering writes ("[Xen-devel] [PATCH] tools/vtpm: use LDLIBS to pass -lgmp"):
> tools/vtpm: use LDLIBS to pass -lgmp
> Linking tpmd will fail with recent toolchains because -lgmp is passed
> via LDFLAGS instead of LDLIBS. With this change -lgpm is placed at the
> end of the gcc cmdline and linking tpmd succeeds again.
>   CFLAGS  += $(WFLAGS) -g -I.. -I. -O2 -fno-strict-aliasing
>  +CFLAGS  += -I../../../../tools/vtpm_manager/manager
> - LDFLAGS += -lgmp
> + LDLIBS  += -lgmp
>  -BINDIR  := /usr/sbin/
>  +BINDIR  := /usr/bin/

Please could you make sure not to include unrelated changes in your
patches.  That makes the job of the reviewer /much/ harder, because we
would have to inspect every hunk of your patches looking for this kind
of thing creeping in.

This is a matter of trust for us as maintainers.  Including an
unrelated hunk once can be put down to a mistake.  Doing it
persistently is a breach of the trust that we as committers need to
place in people who submit patches.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.