[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] qemu-traditional/passthrough: adjust MSI-X device cleanup (bug 1809)

On Mon, 26 Mar 2012, Jan Beulich wrote:
> To address http://bugzilla.xen.org/bugzilla/show_bug.cgi?id=1809,
> pt_unregister_regions() also needs to use the newly introduced
> _pt_iomem_helper() instead of calling xc_domain_memory_mapping()
> directly, to take into consideration the hole created for the MSI-X
> table.
> For this to work, two calls in unregister_real_device() need to be
> swapped, since otherwise we'd have
> unregister_real_device()
>   -> pt_config_delete()
>     -> pt_msix_delete() (frees [and fails to clear] ->msix)
>   -> pt_unregister_regions()
>     -> _pt_iomem_helper() (with the patch below)
>       -> has_msix_mapping() (uses ->msix)
> And to be certain to prevent (catch) further/future use-after-free
> instances, let's also clear dev->msix in pt_msix_delete().
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Tested-by: Yongjie Ren <yongjie.ren@xxxxxxxxx>

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.