Re: [Xen-devel] [PATCH 20/20] libxl: ao: Convert libxl_run_bootloader

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/3/16 Ian Jackson <ian.jackson@xxxxxxxxxxxxx>:
> Convert libxl_run_bootloader to an ao_how-taking function.
>
> It's implemented in terms of libxl__bootloader_run, which can be used
> internally. ÂThe resulting code is pretty much a rewrite.
>
> Significant changes include:
>
> - We provide and use a new asynchronous internal facility for pty
> Âcreation, which runs openpty in a child for SIGCHLD etc. safety
> Â(see the comment at the top of libxl__openptys).
>
> - We direct the bootloader's results to a file, not a pipe. ÂThis
> Âmakes it simpler to deal with as we don't have to read it
> Âconcurrently along with everything else.
>
> - We now issue a warning if we find unexpected statements in the
> Âbootloader results.
>
> - The arrangements for buffering of bootloader input and output
> Âare completely changed. ÂNow we have a fixed limit of 64k
> Âon output, and 4k on input, and discard the oldest data when
> Âthis overflows (which it shouldn't). ÂThere is no timeout
> Âany more.
>
> - This is implemented using a new asynchronous internal data-
> Âcopying facility.
>
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I'm getting the following error when trying to launch DomUs using this patch:

Parsing config file debian.cfg
libxl: debug: libxl_device.c:183:libxl__device_disk_set_backend: Disk
vdev=xvda spec.backend=unknown
libxl: debug: libxl_device.c:137:disk_try_backend: Disk vdev=xvda,
backend phy unsuitable as phys path not a block device
libxl: debug: libxl_device.c:144:disk_try_backend: Disk vdev=xvda,
backend tap unsuitable because blktap not available
libxl: debug: libxl_device.c:219:libxl__device_disk_set_backend: Disk
vdev=xvda, using backend qdisk
libxl: debug: libxl_device.c:183:libxl__device_disk_set_backend: Disk
vdev=xvda spec.backend=qdisk
libxl: debug: libxl.c:1732:libxl_device_disk_local_attach: locally
attaching qdisk /root/vm/disk.img

libxl: error: libxl_utils.c:564:libxl__recvmsg_fds: recvmsg failed
(ptys): Bad file descriptor
libxl: error: libxl_exec.c:124:libxl_report_child_exitstatus: openpty
child [1598] died due to fatal signal Broken pipe
libxl: error: libxl_create.c:570:do_domain_create: failed to run bootloader: -3
xc: debug: hypercall buffer: total allocations:21 total releases:21
xc: debug: hypercall buffer: current allocations:0 maximum allocations:2
xc: debug: hypercall buffer: cache current size:2
xc: debug: hypercall buffer: cache hits:18 misses:2 toobig:1

I haven't tackled down the issue yet, but bisection says it is caused
by this patch.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel