[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 20/20] libxl: ao: Convert libxl_run_bootloader

2012/3/22 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Roger Pau Monnà writes ("Re: [Xen-devel] [PATCH 20/20] libxl: ao: Convert 
> libxl_run_bootloader"):
>> > + Â ÂAC_CHECK_HEADER([libutil.h],[
>> > + Â Â ÂAC_DEFINE([INCLUDE_LIBUTIL_H],[<libutil.h>],[libutil header file 
>> > name])
>> > + Â Â])
> ...
>> Shouldn't you add something like this (or perhaps add the necessary
>> AC_CHECK_HEADER for this headers, so we can get rid of the OS
>> conditional include dependency):
>> #if defined(__NetBSD__) || defined(__OpenBSD__)
>> #include <util.h>
>> #elif defined(__linux__)
>> #include <pty.h>
>> #elif defined(__sun__)
>> #include <stropts.h>
>> #endif
>> #include <utmp.h>
> No, I don't think so. ÂCurrently the only two platforms we really
> support are *BSD and Linux, and I think what I have (include
> <libutil.h> if it exists, and nothing non-portable otherwise) is
> correct.
> Does this test not work on *BSD ?

I haven't tried yet, in fact I have not tried this patch, it's just
that the manpage states that on NetBSD at least you have to include
util.h, it doesn't mention libutil.h.


And the linux man page states that pty.h and utmp.h
(http://linux.die.net/man/3/forkpty) should be included to use this
functions under Linux, but I think you have that covered. Anyway,
those includes are inside libxl_osdeps.h, so if they are not necessary
we should get rid of them, or add the necessary autoconf stuff to
handle that without all the OS conditionals.

> Certainly we don't want these kind of os-specific #ifdefs. ÂIf there
> are multiple possible headers we should call AC_CHECK_HEADER for them.
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.