[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [PATCH v3] Fetch the OVMF repository from specific git mirror and enable it

On 03/20/12 13:12, Attilio Rao wrote:
On 20/03/12 11:57, Christoph Egger wrote:
On 03/20/12 12:09, Attilio Rao wrote:
On 20/03/12 10:06, Christoph Egger wrote:
On 03/19/12 18:50, Attilio Rao wrote:
On 19/03/12 17:40, Attilio Rao wrote:
On 19/03/12 16:36, Ian Jackson wrote:
Attilio Rao writes ("Re: [Xen-devel] [PATCH] [PATCH v3] Fetch the
OVMF repository from specific git mirror and enable it"):
I think I see the issue here. Are you running with i486 as an arch?
This is a deficiency of the OVMF support, because it has some
to build appropriately the firmware which are OS and architectures
specific and it does support Linux-i686 and Linux-x86_64 but not
I'm not sure about what we should do here, possible options
- Verify that, on all i486,i586,etc. we can eventually use i686 and
unify the script to do that
Surely it's just wanting to know roughly what architecture to build
for. The difference between i686 and i486 isn't relevant here.
(I hope. If it is then we have other problems because this is tested
at build-time and might be run on a different kernel to the one it's
built on.)

So I think this is the right thing to do.

Here is my take on OVMF for what is needed:

This should at least fix tianocore to build on all i*86 Linux
Unfortunately I don't have a NetBSD machine to test it out, so if
Christoph and/or Roger can apply this patch to ovmf and try the
original patch on this thread (and verify NetBSD can build ok) I'll
propose this patch upstream for TIANOCORE, otherwise I will just send
out a patch with OVMF disabled until NetBSD is not tested.

To be more precise, you don't even need the patch at the beginning of
the thread, all you need to do to test you can build OVMF on NetBSD
- git clone git://xenbits.xen.org/ovmf.git
- apply the patch above
- cd ovmf/OvmfPkg/
- $ ./build.sh
- $ ./build.sh -a X64
The build fails that build.sh is a bash-script and not a /bin/sh

Please forget my previous e-mail.
I've updated the patch (same link) and I'd be grateful if you can give
it a try now.
I replaced #!/bin/bash with #!/usr/bin/env bash in the entire tree and
get this:

Initializing workspace
WORKSPACE: /data/xen-ovmf/ovmf
EDK_TOOLS_PATH: /data/xen-ovmf/ovmf/BaseTools
Copying $EDK_TOOLS_PATH/Conf/build_rule.template
to $WORKSPACE/Conf/build_rule.txt
Copying $EDK_TOOLS_PATH/Conf/FrameworkDatabase.template
to $WORKSPACE/Conf/FrameworkDatabase.txt
Copying $EDK_TOOLS_PATH/Conf/tools_def.template
to $WORKSPACE/Conf/tools_def.txt
Copying $EDK_TOOLS_PATH/Conf/target.template
to $WORKSPACE/Conf/target.txt
Building tools as they are not in the path
SourceCMakefilesNmakeSubdirs.bat: not found

Yes, you also need to replace make with gmake in installation scripts.

Ok, you should allow to pass $(MAKE) to build.sh when building from the
Xen tree.

I get this now:

$ ./build.sh
Initializing workspace
Loading previous configuration from $WORKSPACE/Conf/BuildEnv.sh
WORKSPACE: /data/xen-ovmf/ovmf
EDK_TOOLS_PATH: /data/xen-ovmf/ovmf/BaseTools
Building tools as they are not in the path
gmake: Entering directory `/data/xen-ovmf/ovmf/BaseTools'
gmake -C Source/C
Attempting to detect ARCH from 'uname -m': amd64
Could not detected ARCH from uname results
gmake[1]: Entering directory `/data/xen-ovmf/ovmf/BaseTools/Source/C'
GNUmakefile:33: *** ARCH is not defined!.  Stop.
gmake[1]: Leaving directory `/data/xen-ovmf/ovmf/BaseTools/Source/C'
gmake: *** [Source/C] Error 2
gmake: Leaving directory `/data/xen-ovmf/ovmf/BaseTools'

(Sorry but I really don't have now a NetBSD machine to test on, so I
cannot really catch even silly mistakes).
Installing NetBSD in a virtual machine is not an option?

I'm trying that with a native FreeBSD, will let you know once I have a
patch ready to go.


---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.