Re: [Xen-devel] [PATCH 03/20] libxl: Fix eventloop_iteration over-locking

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-03-19 at 17:48 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 03/20] libxl: Fix 
> eventloop_iteration over-locking"):
> > A comment in eventloop_iteration along the lines "no need to lock, we
> > must be called with lock held once" might be nice to prevent future
> > re-occurences of the same error.
> 
> You don't see it in this patch, but there's something along these
> lines already.  Let me add some more context:
> 
> > > @@ -1058,8 +1058,6 @@ static int eventloop_iteration(libxl__egc *egc, 
> > > libxl__poller *poller) {
>      static int eventloop_iteration(libxl__egc *egc, libxl__poller *poller) {
>          /* The CTX must be locked EXACTLY ONCE so that this function
>           * can unlock it when it polls.
>           */

Brilliant, thanks!

>          EGC_GC;
> > >      int rc;
> > >      struct timeval now;
> > >      
> > > -    CTX_LOCK;
> > > -
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel