[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tapdisk2: initialize 'name' parameter of BLKTAP2_IOCTL_CREATE_DEVICE

Jan Beulich writes ("Re: [Xen-devel] [PATCH] tapdisk2: initialize 'name' 
> >  |        Warning: If there is no null byte among the first n bytes
> >  | of src, the string placed in dest will not be null-terminated.
> That's actually expected here - the kernel code needs to be careful
> about no trailing NUL anyway.

Oh, OK.

> > An easy fix would be to memset params to 0 first.
> That would not help at all - if src is longer than available space, then
> there still wouldn't be a NUL in the end. On would additionally have to
> subtract 1 from the size argument. But as said, all that is unnecessary.

Yes, I realised that suggestion of mine was confused.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.