Re: [Xen-devel] [PATCH 1 of 2] Propagate domain shared pages via dominfo

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-03-12 at 19:53 +0000, Andres Lagar-Cavilla wrote:
> tools/libxc/xc_domain.c     |  2 +-
>  xen/common/domctl.c         |  2 +-
>  xen/include/public/domctl.h |  2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> 
> Currently commented out, no reason to disable it.
> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> diff -r addb6616e282 -r 94ec84eeca5d xen/include/public/domctl.h
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -94,7 +94,7 @@ struct xen_domctl_getdomaininfo {
>      uint32_t flags;              /* XEN_DOMINF_* */
>      uint64_aligned_t tot_pages;
>      uint64_aligned_t max_pages;
> -    /* uint64_aligned_t shr_pages; */
> +    uint64_aligned_t shr_pages;
>      uint64_aligned_t paged_pages;
>      uint64_aligned_t shared_info_frame; /* GMFN of shared_info struct */
>      uint64_aligned_t cpu_time;

This doesn't appear to be commented out here, xen-unstable
25007:5d20d2f6ffed:

$ grep -A 4 -B 4 shr_pages xen/include/public/*
xen/include/public/domctl.h-#define XEN_DOMINF_shutdownshift 16
xen/include/public/domctl.h-    uint32_t flags;              /* XEN_DOMINF_* */
xen/include/public/domctl.h-    uint64_aligned_t tot_pages;
xen/include/public/domctl.h-    uint64_aligned_t max_pages;
xen/include/public/domctl.h:    uint64_aligned_t shr_pages;
xen/include/public/domctl.h-    uint64_aligned_t paged_pages;
xen/include/public/domctl.h-    uint64_aligned_t shared_info_frame; /* GMFN of 
shared_info struct */
xen/include/public/domctl.h-    uint64_aligned_t cpu_time;
xen/include/public/domctl.h-    uint32_t nr_online_vcpus;    /* Number of VCPUs 
currently online. */

I didn't look at the other hunks after I noticed this. I can't see
anywhere in history where it was commented out -- perhaps a local patch
on your end?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel