Re: [Xen-devel] [PATCH v2] autoconf: check for Python.h header and -lpython* lib

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/3/12 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Roger Pau Monne writes ("[PATCH v2] autoconf: check for Python.h header and 
> -lpython* lib"):
>> autoconf: check for Python.h header and -lpython* lib
>
> Right, this is better.
>
>> +ac_previous_cppflags=$CPPFLAGS
> ...
>> +AC_CHECK_HEADER([Python.h], [],
>> + Â Â[AC_MSG_ERROR([Unable to find Python development headers])],)
>> +AC_CHECK_LIB($python_lib, PyArg_ParseTuple, [],
>> + Â Â[AC_MSG_ERROR([Unable to find a suitable python development library])])
>> +CPPFLAGS=$ac_previous_cppflags
>> +LDLFAGS=$ac_previous_ldflags
>
> But AFAICT we go to all this effort to find the right python flags and
> then we throw them away. ÂThis is a bit odd. ÂShouldn't we be passing
> this in some PYTHON_FOOFLAGS variables for the benefit of tools/python ?

This would only be needed to compile Python C modules, but since
python uses it's own standart build script (tools/python/setup.py) and
we already pass to the setup.py script the desired python version to
use, it already fetches the necessary includes/libs using it's own
mechanisms.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel