Re: [Xen-devel] [PATCH 3 of 3] autoconf: check for Python.h header and -lpython lib

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH 3 of 3] autoconf: check for Python.h header and 
-lpython lib"):
> +    AS_IF([test ${flag:0:2} = "-L"], [

This syntax, ${flag:0:2}, is not POSIX.  You should use case.  I think
we can safely dispense with the use of AS_IF.

> +        LDFLAGS="$LDLFAGS $flag"
> +    ])
> +    AS_IF([test ${flag:0:8} = "-lpython"], [
> +        python_lib=${flag:2}
> +    ])

I see that you are throwing away all other -l* options.  This deserves
a comment.  You probably also want to barf if you find options which
are not -L or -l.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel