Re: [Xen-devel] [PATCH] Low mem virq incremental adjustments

["Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>]

>  >>> On 07.03.12 at 17:15, Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> wrote:
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -377,7 +377,10 @@ static void __init setup_low_mem_virq(vo
>>
>>  static void check_low_mem_virq(void)
>>  {
>> -    if ( unlikely(total_avail_pages <= low_mem_virq_th) )
>> +    unsigned long avail_pages = total_avail_pages +
>> +                (opt_tmem) ? tmem_freeable_pages(): 0;
>
> Can tmem_freeable_pages() return anything other than zero when
> opt_tmem is zero? (I.e. is the [improperly parenthesized!] conditional
> expression necessary at all?)

I'm not sure. I'll let Dan take it from here, as he surely knows the right
way. He acked it the way it is.
Andres

>
> Jan
>
>> +
>> +    if ( unlikely(avail_pages <= low_mem_virq_th) )
>>      {
>>          send_global_virq(VIRQ_ENOMEM);
>>
>> @@ -391,7 +394,7 @@ static void check_low_mem_virq(void)
>>          return;
>>      }
>>
>> -    if ( unlikely(total_avail_pages >= low_mem_virq_high) )
>> +    if ( unlikely(avail_pages >= low_mem_virq_high) )
>>      {
>>          /* Reset hysteresis. Bring threshold up one order.
>>           * If we are back where originally set, set high
>
>
>
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel