[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] hvm: Correct RTC time offset update error due to tm->tm_year

On 2012-2-23 22:52, annie li wrote:

On 2012-2-22 21:58, Ian Campbell wrote:

Yes, this looks plausible to me (although I'm no expert on this code).
Something similar happens in rtc_next_second.
Perhaps it would be better to add a function or macro to do the
conversion, such that it is somewhat self documenting? Or at least make
the 1900 a #define with a suitable name.
I changed the 1900 to a macro and added a new function get_year. The new patch is attached.
Sorry, two macro define: epoch_year and get_year.



Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.