Re: [Xen-devel] [xen-unstable test] 12007: regressions - FAIL

[Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>]

2012/2/22 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 12007: regressions 
> - FAIL"):
>> This is why I am concerned that we have removed the install time as well
>> as the development time checks...
>
> This is a legitimate concern but these checks should definitely not be
> in the configure script, so I've applied Roger's patches to remove
> them.
>
>> Perhaps we should move these new checks to a second configure script
>> which can be run at install time and produces as its output just a pass
>> or fail?
>
> Roger Pau Monnà writes ("Re: [Xen-devel] [xen-unstable test] 12007: 
> regressions - FAIL"):
>> I've submitted a patch that should fix that. I'm afraid that removing
>> the brctl/brconfig check will bring trouble, because this is used in
>> hotplug scripts and errors on hotplug scripts are hard to spot right
>> now for regular users.
>
> This should definitely be fixed.
>
> I think the right answer is to add some checks in xencommons. ÂSince
> the purpose is to help the user diagnose problems, it's fine for them
> to be warnings rather than causing xencommons not to work at all.

I was going to create a new configure script to perform those checks,
but maybe it's overkill. I will add some simple tests to xencommons.

> And given that we only want to check for brctl and udev, and those are
> pretty simple, I don't think we need to use autoconf for that.
>
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel