Re: [Xen-devel] xc_gnttab_get_version question/bug

[Francisco Rocha <f.e.liberal-rocha@xxxxxxxxxxxxxxx>]

________________________________________
From: Ian Campbell [Ian.Campbell@xxxxxxxxxx]
Sent: 14 February 2012 12:52
To: Francisco Rocha
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Keir (Xen.org)
Subject: Re: [Xen-devel] xc_gnttab_get_version question/bug

On Tue, 2012-02-14 at 12:44 +0000, Ian Campbell wrote:
> I've no idea where this might be coming from though.

Turns out I do... The following fixes it for me. Ought to be backported
IMHO.

Ian.

Thank you, it also solves the problem for me.

Francisco


# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1329223776 0
# Node ID 86ebf7589758da1d026175ac46b3f9bda75f0937
# Parent  43f94d0d384b1c00b5d8fc9a90d6d48165cd854d
xen: add missing unlock from gnttab_get_version

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Reported-by: Francisco Rocha <f.e.liberal-rocha@xxxxxxxxxxxxxxx>

diff -r 43f94d0d384b -r 86ebf7589758 xen/common/grant_table.c
--- a/xen/common/grant_table.c  Tue Feb 14 12:40:13 2012 +0000
+++ b/xen/common/grant_table.c  Tue Feb 14 12:49:36 2012 +0000
@@ -2321,6 +2321,8 @@ gnttab_get_version(XEN_GUEST_HANDLE(gntt
     op.version = d->grant_table->gt_version;
     spin_unlock(&d->grant_table->lock);

+    rcu_unlock_domain(d);
+
     if ( copy_to_guest(uop, &op, 1) )
         return -EFAULT;




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel