[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] arm: fixup hard tabs

On Mon, 2012-02-13 at 19:39 +0000, Tim Deegan wrote:
> At 19:09 +0000 on 13 Feb (1329160194), Ian Campbell wrote:
> > (note that the mangling resulted in _7_ space indentation, which is
> > worse than just about anything)
> > 
> > > No other file in the tree has tabs why should these?
> > > 
> > > Nak, unless your intention is to immediately apply a patch converting
> > > tabs to 8 spaces.
> We really ought to take this - the current state is both accidental and
> nonsensical.

Yes, that is my primary concern right now.

> That said, for head.S, which is the only place I've introduced tabs, I'm
> happy to have the whole file converted to (8) spaces if you also fix the
> emacs runes at the foot of the file to DTRT.

Similarly for entry.S which I think I just styled after head.S.

> For asm code taken from linux, have we already mangled them enough
> that applying upstream fixes would be hard?

I don't think so, once this fix is applied they will be back to being
pretty close.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.