Re: [Xen-devel] [PATCH] arm: fixup hard tabs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-02-13 at 18:26 +0000, David Vrabel wrote:
> On 13/02/12 18:03, Ian Campbell wrote:
> > # HG changeset patch
> > # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> > # Date 1329153968 0
> > # Node ID 63e88a26e1ef58c8e5a2b30a003ab7c3bc9c6b54
> > # Parent  7fd8f10cfd3eaf9f0982eb6fd49334a1e229ba98
> > arm: fixup hard tabs
> > 
> > Unfortunately the tool I was using to apply patches mangles hard tabs. This
> > patch corrects this in the effected files (which is fortunately only a 
> > subset
> > of .S or files imported from Linux)

(note that the mangling resulted in _7_ space indentation, which is
worse than just about anything)

> 
> No other file in the tree has tabs why should these?
> 
> Nak, unless your intention is to immediately apply a patch converting
> tabs to 8 spaces.

My intention is to put the tree back into the state which reflects what
the original authors intended, that is what I was sent and what I would
have committed if my tools had not let me down. I am not going to do any
more or less than that.

I'm not really interested in debating the right style of indentation to
use in the context of this fixup patch. If you feel strongly about it
please follow up with a patch with the explicit purpose of changing the
_intended_ indentation.

> Interestingly, the citrix email server apears to mangle tabs and replace
> them with spaces (which made the copy of these patch I received via Cc
> appear to do nothing at all). Perhaps this is where it went wrong
> originally?

Quite possibly. I may need to investigate alternative ways of receiving
patches which I intend to apply if that turns out to be the case.

> > @@ -1,2 +1,2 @@
> > -        .section .dtb,#alloc
> > -        .incbin CONFIG_DTB_FILE
> > +   .section .dtb,#alloc
> > +   .incbin CONFIG_DTB_FILE
> 
> This was a new file that never had tabs anywhere. No need to mess about
> with it.

That being the case I'll drop this hunk.

Thanks,
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel