Re: [Xen-devel] [PATCH v2 3/3] firmware: Introduce CONFIG_ROMBIOS and CONFIG_SEABIOS options

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-02-10 at 01:53 +0000, Julian Pidancet wrote:
> @@ -470,6 +472,7 @@ int main(void)
>              bios->create_pir_tables();
>      }
>  
> +#ifdef ENABLE_ROMBIOS
>      if ( bios->load_roms )

Can we make bios->load_roms a function pointer instead of a bool. It can
be NULL for SeaBIOS and contain this block on ROMBIOS? Then all this
code (and pci_load_option_roms) could be moved to rombios.c.

>      {
>          switch ( virtual_vga )
> @@ -506,6 +509,7 @@ int main(void)
>          option_rom_sz = pci_load_option_roms(bios->optionrom_end,
>                                               option_rom_phys_addr);
>      }
> +#endif
>  
>      acpi_enabled = !strncmp(xenstore_read("platform/acpi", "1"), "1", 1);
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel