Re: [Xen-devel] [PATCH v2 2/3] firmware: Use mkhex from hvmloader directory for etherboot ROMs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-02-10 at 01:53 +0000, Julian Pidancet wrote:
> @@ -95,10 +97,11 @@ ifneq ($(CIRRUSVGA_ROM),)
>       sh ./mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new
>       echo "#endif" >> $@.new
>  endif
> -
> +ifneq ($(ETHERBOOT_ROMS),)
>       echo "#ifdef ROM_INCLUDE_ETHERBOOT" >> $@.new
> -     cat ../etherboot/eb-roms.h >> $@.new
> +     sh ./mkhex etherboot $(ETHERBOOT_ROMS) >> $@.new

mkhex uses $1 as the array name and $2 as the binary data. However if
ETHERBOOT_ROMS contains two or more items then the second and subsequent
roms will be $3,$4 etc which are then not included.

I think you need to either quote something somewhere, use shift and $@
in mkhex or stick with the "cat $(ETHERBOOT_ROMS) | ./mkhex ..." style.

The rest of the patch looked good, thanks.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel