Re: [Xen-devel] [PATCH 3 of 5] blkif.h: Add definitions for virtual block device major numbers

["Justin T. Gibbs" <justing@xxxxxxxxxxxxxxxx>]

On Feb 7, 2012, at 10:33 AM, Ian Jackson wrote:

> Justin T. Gibbs writes ("[Xen-devel] [PATCH 3 of 5] blkif.h: Add definitions 
> for virtual block device major numbers"):
> > +/*
> > + * Xen-defined major numbers for virtual block devices.
> > + */
>
> Isn't this the same thing as is in
>  docs/misc/vbd-interface.txt
> only expressed differently ?

Ian.

I wasn't aware of this file.  After a brief look, it seems there is
information missing from both vbd-interface.txt and blkif.h.  Per
vbd-interface.txt, there is also an error in blkif.h.  The "virtual-device"
node must tolerate 32bit integers.

I'll fix the size specification for the "virtual-device" node, but how
should I reconcile blkif.h and vbd-interface.txt.  I hate information
duplication since one version is invariably stale.

--
Justin


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel