Re: [Xen-devel] [PATCH 2 of 5] blkif.h: Provide more complete documentation of the blkif interface

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Justin T. Gibbs writes ("[Xen-devel] [PATCH 2 of 5] blkif.h: Provide more 
complete documentation of the blkif interface"):
>   o Document the XenBus nodes used in this protocol

Awesome.  But I don't think all of these are really supposed to be
part of the guest interface, so you should probably mention which ones
are.

For example,

> + * params
> + *      Values:         string

this is not intended for use by guests and they should not look at it.

> + * virtual-device
> + *      Values:         <uint16_t> (XEN_*_MAJOR << 8 | Minor)

This should be a reference to docs/misc/vbd-interface.txt.  But isn't
this also encoded in the device path in xenstore ?

I'm not qualified to comment on the state machine.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel