Re: [Xen-devel] [PATCH 1 of 6] libxl: helper function to send commands to traditional qemu

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Tue, Jan 31, 2012 at 1:46 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

On Tue, 2012-01-31 at 01:05 +0000, rshriram@xxxxxxxxx wrote:
> # HG changeset patch
> # User Shriram Rajagopalan <rshriram@xxxxxxxxx>
> # Date 1327971493 28800
> # Node ID 20bbc4a754a701ef14c9136a1adffc1c90bc1f4a
> # Parent  e2722b24dc0962de37215320b05d1bb7c4c42864
> libxl: helper function to send commands to traditional qemu
>
> Introduce a helper function to send commands to traditional
> qemu. qemu_pci_add_xenstore, qemu_pci_remove_xenstore,
> libxl__domain_save_device_model and libxl_domain_unpause have
> been refactored to use this function.
>
> Signed-off-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Every caller to libxl__qemu_traditional_cmd seems to be followed with a
call to libxl__wait_for_device_model -- might be worth pushing that down
into the function?

Yes I noticed that. Though some seem to be using the callback while others dont.
This would necessitate another helper function, like libxl_qemu_traditional_change_state

that does both the command and the state check (if callback supplied). This
way people could still use the libxl_qemu_traditional_cmd for use-cases that dont
require a special state check. But all this is for another , later patch :P. At the moment,

I just want to get the remus framework in :D.

thanks for the ack.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel