Re: [Xen-devel] [PATCH] pv drivers: wrap xen_cpuid_base()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.01.12 at 11:27, Olaf Hering <olaf@xxxxxxxxx> wrote:
> On Mon, Jan 23, Jan Beulich wrote:
> 
>> sle11sp2 (3.0): building fine.)
> 
> Not for the xen.src.rpm, it also contains this change. I think the

Oh, I wasn't even aware of that custom change of ours.

> reason is that the kernel sources are searched before the xen sources
> for asm/hypervisor.h:
> 
> /usr/src/linux-3.0.13-0.11/arch/x86/include/asm/hypervisor.h
> /usr/src/packages/BUILD/xen-4.2.24547/non-dbg/obj/default/include/asm/hypervisor.h
>...
> Its probably not a bug to prefer kernel-source over local directories.

Agreed.

While it's still a hack (what if the function got un-inlined and exported),

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel