Re: [Xen-devel] [PATCH] pv drivers: wrap xen_cpuid_base()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.01.12 at 15:22, Olaf Hering <olaf@xxxxxxxxx> wrote:
> On Mon, Jan 23, Jan Beulich wrote:
> 
>> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
>> 
>> Given that the PV drivers must be building fine for SLE11 SP2, which
>> is 3.0-based, I wonder if this really is the correct fix (and doesn't
>> rather break the build). The first thing coming to mind is that
>> arch/x86/include/asm/xen/hypervisor.h shouldn't get included here
>> (and hence there shouldn't be any conflict). Are you perhaps trying
>> to build the PV drivers against a pv-ops-enabled configuration (which
>> is a wrong to try afaict)?
> 
> Its an ordinary kernel-source tree.

That's not the question - it matters what your .config is set to.

> git describe d9b8ca8474fd4fdd43ba6d97a4fee8b49b978067
> v2.6.37-rc5-2-gd9b8ca8

How is 2.6.37-rc5 related to this?

> The function appears in 2.6.38, so I think the version number is correct.

The version number appears to be correct (in 2.6.36 and 2.6.37 the
function existed, but was static in arch/x86/xen/enlighten.c), but
again that wasn't my point. Instead you will want to point out how
you ended up including the declaring header. (I'm running the PV
driver build every once in a while, and I know it had worked fine for
SLE11 SP2 sources a while back. Let me see how things look right
now:

master (3.2): getting an unrelated error apparently due to a missing
header inclusion, platform-pci/platform-pci.c building fine

sle11sp2 (3.0): building fine.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel