Re: [Xen-devel] [PATCH 3/3] xenoprof: Make the escape code consistent across 32 and 64-bit xen

[Keir Fraser <keir@xxxxxxx>]

On 23/01/2012 16:51, "George Dunlap" <george.dunlap@xxxxxxxxxx> wrote:

> On Mon, 2012-01-23 at 16:30 +0000, Jan Beulich wrote:
>>> The attached patch fixes the build (with the original patch un-reverted
>>> of course), by making the internal calls explicitly take 64-bit values
>>> for eip, rather than "unsigned long".  Will that suffice?
>> 
>> Looks correct and sufficient, but with the original patch already
>> reverted folding the changes here into the original and re-submitting
>> would probably the best route to go.
> 
> I really prefer to keep patches with no functional change separate from
> those with a pretty major functional change; even if the major
> functional change is only one line. :-)

The one-line major functional change didn't work. Obviously the other
changes to make it build must be part of the same logical patch.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel