[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] xenoprof: Make the escape code consistent across 32 and 64-bit xen

>>> On 23.01.12 at 17:51, George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
> On Mon, 2012-01-23 at 16:30 +0000, Jan Beulich wrote:
>> > The attached patch fixes the build (with the original patch un-reverted
>> > of course), by making the internal calls explicitly take 64-bit values
>> > for eip, rather than "unsigned long".  Will that suffice?
>> Looks correct and sufficient, but with the original patch already
>> reverted folding the changes here into the original and re-submitting
>> would probably the best route to go.
> I really prefer to keep patches with no functional change separate from
> those with a pretty major functional change; even if the major
> functional change is only one line. :-)

Not sure I follow - the (now reverted) patch was buggy, so why not
fix the patch and re-submit? And besides - the fixup patch is certainly
not "no functional change", at least not on 32-bits.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.