[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 29 of 32 RFC] libxl: add named enum for timer mode

On Mon, 2012-01-16 at 16:27 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 29 of 32 RFC] libxl: add named 
> enum for timer    mode"):
> > I'm happy to take either approach to be honest. I imagine most _init
> > functions will turn into just a memset anyway at which point maybe we
> > should just ditch them.
> > 
> > I'd rather either all data types had an init or none is my only real
> > feeling on the matter.
> I absolutely agree.  (The init function could be autogenerated.)

OK, I shall arrange that each type libxl_FOO has a libxl_FOO_init which
cannot fail and which is (normally) generated from the IDL. Likewise I
will arrange for a libxl_FOO_setdefaults which can fail.

This gives us the freedom to have non-zero representation for the
default on a per-type or per-field exceptional basis.

This will however make this series even larger...

> > > we could decree that all-bits-set means "use default value".
> > 
> > Do you mean in genral or just this specific field?
> In general.
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.