Re: [Xen-devel] [PATCH 29 of 32 RFC] libxl: add named enum for timer mode

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-01-16 at 16:17 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 29 of 32 RFC] libxl: add named enum 
> for timer mode"):
> > libxl: add named enum for timer mode.
> > 
> > In order to have 0 == default the specific values are off-by-one from the
> > underlying domctl. I'm not sure I like this.
> 
> If we're abolishing the idea of memsetting infos to 0, and instead
> requiring everyone to call _init, 

I'm happy to take either approach to be honest. I imagine most _init
functions will turn into just a memset anyway at which point maybe we
should just ditch them.

I'd rather either all data types had an init or none is my only real
feeling on the matter.

> we could decree that all-bits-set means "use default value".

Do you mean in genral or just this specific field?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel