[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/10] libxl: move a lot more includes into libxl_internal.h

On Fri, 2012-01-13 at 13:37 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 03/10] libxl: move a lot more 
> includes into libxl_internal.h"):
> > Could we put this first in libxl_internal.h and apply that constraint to
> > that header instead?
> In theory, yes.  But in practice people very much seem to like to add
> new system headers to individual files.  And if you forget and add
> them in the wrong place it can lead to subtle portability bugs which
> you might not notice.
> So I think this is a more obvious way to do it, even though it's an
> extra #include line in each file.

Sure, that fine.

I suppose using -include (or whatever its real name is) on the compiler
command line is too skanky?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.