[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03/10] libxl: move a lot more includes into libxl_internal.h



Ian Campbell writes ("Re: [Xen-devel] [PATCH 03/10] libxl: move a lot more 
includes into libxl_internal.h"):
> Could we put this first in libxl_internal.h and apply that constraint to
> that header instead?

In theory, yes.  But in practice people very much seem to like to add
new system headers to individual files.  And if you forget and add
them in the wrong place it can lead to subtle portability bugs which
you might not notice.

So I think this is a more obvious way to do it, even though it's an
extra #include line in each file.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.