Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning message to include domain id.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Jan 06, 2012 at 03:51:25PM +0000, Ian Campbell wrote:
> On Fri, 2012-01-06 at 15:03 +0000, Konrad Rzeszutek Wilk wrote:
> > On Fri, Jan 06, 2012 at 08:38:09AM +0000, Jan Beulich wrote:
> > > >>> On 05.01.12 at 01:46, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 
> > > >>> wrote:
> > > > When a PCI device is transferred to another domain and it is still
> > > > in usage (from the internal perspective), mention which other
> > > > domain is using it to aid in debugging.
> > > > 
> > > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > > > ---
> > > >  drivers/xen/xen-pciback/xenbus.c |    6 ++++--
> > > >  1 files changed, 4 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/xen/xen-pciback/xenbus.c 
> > > > b/drivers/xen/xen-pciback/xenbus.c
> > > > index 474d52e..fa130bd 100644
> > > > --- a/drivers/xen/xen-pciback/xenbus.c
> > > > +++ b/drivers/xen/xen-pciback/xenbus.c
> > > > @@ -243,8 +243,10 @@ static int xen_pcibk_export_device(struct 
> > > > xen_pcibk_device *pdev,
> > > >         dev_dbg(&dev->dev, "registering for %d\n", 
> > > > pdev->xdev->otherend_id);
> > > >         if (xen_register_device_domain_owner(dev,
> > > >                                              pdev->xdev->otherend_id) 
> > > > != 0) {
> > > > -               dev_err(&dev->dev, "device has been assigned to another 
> > > > " \
> > > > -                       "domain! Over-writting the ownership, but 
> > > > beware.\n");
> > > > +               int other_domain = xen_find_device_domain_owner(dev);
> > > > +               dev_err(&dev->dev, "device has been assigned to %d " \
> > > > +                       "domain! Over-writting the ownership, but 
> > > > beware.\n",
> > > > +                       other_domain);
> > > 
> > > As you're touching this anyway, how about fixing the other minor
> > > issues with it too? E.g.
> > > 
> > >           dev_err(&dev->dev, "Device appears to be assigned to dom%d!"
> > >                   " Overwriting the ownership, but beware.\n",
> > >                   xen_find_device_domain_owner(dev));
> > > 
> > > (a native English speaker may want to comment the "but beware"
> > > part - it reads odd for me).
> > 
> > Hm, lets ask the English speakers. Ian?
> 
> I think you underestimate a native speakers ability to mangle a
> language. Especially this one ;-)
> 
> Anyway, I think it's unnecessary, so you may as well drop it and just
> have:
> 
>               dev_err(&dev->dev, "Device appears to be assigned to dom%d!"
>                       " Overwriting the ownership.\n",
>                       xen_find_device_domain_owner(dev));
> 
> I suppose you might want "Overriding ownership to dom%d".

OK. To the point and potentially can fit in 80 lines :-).

Will spin out the patch next week-sih.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel