[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Only retry mapping pages when ENOENT is returned

Adin Scannell writes ("[Xen-devel] [PATCH] Only retry mapping pages when ENOENT 
is returned"):
> Only retry mapping pages when ENOENT is returned
> If the return value from the ioctl() is not ENOENT, it's possible that err[i]
> will not be updated and libxc will just loop forever.  Although it's unlikely
> that err[i] would not be updated after the ioctl() gets through at least once,
> it's better to be defensive.

I confess I don't understand the intended error handling here.  AFAICT
this ioctl leaves a separate errno value for each request, in the
array.  Presumably, however, it can also fail entirely and not update
the separate in-array errno values.

So how does one tell which of these is the case ?

CCing Jan since it looks like his code originally, in 20791:0b138a019292


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.