[Xen-devel] Re: [PATCH 1 of 3 V6] tools/libxc: introduce page_aligned_alloc in xc_{minios, linux, solaris, netbsd}.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2011-11-08 at 22:39 +0000, rshriram@xxxxxxxxx wrote:
> diff -r 54a5e994a241 -r 58a24a7d4b87 tools/libxc/xc_linux_osdep.c
> --- a/tools/libxc/xc_linux_osdep.c    Wed Nov 02 17:09:09 2011 +0000
> +++ b/tools/libxc/xc_linux_osdep.c    Tue Nov 08 14:26:02 2011 -0800
> @@ -36,9 +36,17 @@
>  #include <xen/sys/gntdev.h>
>  #include <xen/sys/gntalloc.h>
>  
> +#include "xc_private.h"

I'd like to avoid including xc_private from this file. Although it's in
tree it is a plugin and avoiding internal APIs serves to help ensure
that external plugins can actually be written using the public APIs.

I think you can make this function public, as long as you name it
xc_blah.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel