Re: [Xen-devel] [PATCH 1 of 7] [OCAML] Rename the ocamlfind packages

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Fri, 2011-09-30 at 13:19 +0100, Jonathan Ludlam wrote:
> On 30 Sep 2011, at 08:42, Ian Campbell wrote:
> 
> > On Thu, 2011-09-29 at 22:17 +0100, Jon Ludlam wrote:
> >> ocamlfind does not support namespaces, so to avoid
> >> name clashes the ocamlfind package names have been
> >> changed. Note that this does not change the names
> >> of the actual modules themselves.
> > 
> > So you do "ocamlfind xenbus" in your code but subsequently "import" xl.*
> > (forgive my lack of actual ocaml syntax)?
> > 
> > I'm happy with that if its acceptable practice in ocaml, but given it's
> > "just" a sed invocation away should we bite the bullet and change the
> > module name too?
> > 
> 
> It's not uncommon, e.g. the 'threads' package allows the use of the
> Thread, Mutex, Condition, Event and ThreadUnix modules, but not a
> 'Threads' one. Having said that, for the single module packages it
> would be slightly odd. The only thing that stopped me is that what I
> did involves a change in the makefiles of any ocaml project using the
> libs, whereas a renaming of the modules would require changing a lot
> more code. Being a bit ambivalent about the two approaches, I picked
> the one that was less noisy, though I'm willing to be persuaded
> otherwise.

Thanks -- seems reasonable. I'm don't see any reason to try and persuade
you any further ;-)

> 
> >> xb becomes xenbus, xc becomes xenctrl, xl becomes xenlight,
> >> xs becomes xenstore, eventchn becomes xeneventchn.
> > 
> > The next patch removes uuid which by my count leaves just the mmap
> > library, any plans for that one?
> > 
> 
> We haven't quite figured out what to do with that one yet. It depends
> a little on whether anything else is using the module. More to
> follow :-)

Great!



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel