Re: [Xen-devel] [PATCH 4 of 7] [OCAML] Fix a problem with ocaml xenstored

[Jonathan Ludlam <Jonathan.Ludlam@xxxxxxxxxxxxx>]

Ah, that's a shame. I was hoping this was a bugfix to the ocaml xenstored and 
that the C version already did this. Unfortunately the patch here went in to 
XenServer a couple of years ago, and Thomas, who made the change, has since 
left. I'll dig into this and see why we depend upon it. 

Jon
 
On 30 Sep 2011, at 08:49, Ian Campbell wrote:

> On Thu, 2011-09-29 at 22:17 +0100, Jon Ludlam wrote:
>> Have xenstored trigger an @introduceDomain event even if the
>> introduce call tries to introduce an already existing domain.
> 
> The C daemon doesn't appear to behave this way. It would be nice to
> explain why this change is necessary. 
> 
>> Signed-off-by: Thomas Gazagnaire <thomas@xxxxxxxxxxxx>
>> Acked-by: Jon Ludlam <jonathan.ludlam@xxxxxxxxxxxxx>
>> 
>> diff -r 734cb0807357 -r b6022a18ebb0 tools/ocaml/xenstored/process.ml
>> --- a/tools/ocaml/xenstored/process.ml
>> +++ b/tools/ocaml/xenstored/process.ml
>> @@ -168,9 +168,10 @@
>>              | _                         -> raise Invalid_Cmd_Args;
>>              in
>>      let dom =
>> -            if Domains.exist domains domid then
>> +            if Domains.exist domains domid then begin
>> +                    Connections.fire_spec_watches cons "@introduceDomain";
>>                      Domains.find domains domid
>> -            else try
>> +            end else try
>>                      let ndom = Xc.with_intf (fun xc ->
>>                              Domains.create xc domains domid mfn port) in
>>                      Connections.add_domain cons ndom;
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel