Re: [Xen-devel] [PATCH] tools: ocaml: fix the logging in the ocaml libxl bindings

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

David Scott writes ("[Xen-devel] [PATCH] tools: ocaml: fix the logging in the 
ocaml libxl bindings"):
> tools: ocaml: fix the logging in the ocaml libxl bindings.
> 
> We now:
> 1. ensure the caml_logger fields have sensible initial values
> 2. adopt the policy that, if the messages won't fit into the buffer then
>    they are dropped and clipped is set to 1. The default buffer size is 2KiB
>    which ought to be large enough unless the logging is very spammy (which
>    is arguably a problem in itself)

Thanks, but:

 * Can you make a version where the line lengths do not exceed 75 ?
   That allows for a patch +/- column, plus a couple of levels of
   quoting, to fit in an 80-column window.

 * Now that I read this code I'm very confused.  Why does log_vmessage
   not actually output the message anywhere ?  Looking at the code,
   the buffer is printed out only if the call fails (I assume that's
   what failwith_xl is).  That's not right.  What about debugging
   output ?

   There is no guarantee that the logger will be called to report any
   particular number of messages if a libxl call fails.  Specifically,
   it may output zero error messages, or several one, before returning
   a failure code.  And it will frequently output a number of
   informational messages.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel