Re: [Xen-devel] [PATCH 6/6] libxl: vncviewer: make autopass work properly

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 4 Feb 2011, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 6/6] libxl: vncviewer: 
> make autopass work properly"):
> > Even though it might be tolerable to have this function exits, I still
> > don't see any benefits as opposed to failing with an error, considering
> > that this function returns an integer and the long term plan would be
> > to return an error anyway.
> 
> Very well, how about this.
> 
> > It is just a matter of checking the return value in
> > tools/libxl/xl_cmdimpl.c:vncviewer.
> 
> It already does.  (Nice to see, for a change.)
> 
> Ian.
> 
> 
> libxl: vncviewer: make autopass work properly
> 
> The file we write the vnc password to must be rewound back to the
> beginning, or the vnc viewer will simply get EOF.
> 
> When the syscalls for communicating the password to the vnc client
> fail, bomb out with an error messsage rather than blundering on (and
> probably producing a spurious password prompt).
> 
> Following this patch, xl vncviewer --autopass works, provided the qemu
> patch for writing the password to xenstore has also been applied.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

this patch and the rest of the series:

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel