[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 6/6] libxl: vncviewer: make autopass work properly
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 6/6] libxl: vncviewer: make autopass work properly"): > On Tue, 1 Feb 2011, Ian Jackson wrote: > > + if ( autopass_fd < 0 ) { > > + LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, > > + "mkstemp %s failed", tmpname); > > + exit(-1); > > + } > > I don't think we should call exit here, this is a library not an > executable. However instead of just skipping autopass we should avoid > exec'ing vncviewer completely and return and error. The caller must already tolerate the function simply causing the process to die, because execve can fail like that. Ie, libxl_exec_vncviewer is already called only after fork. So it seemed best to have the function always fail the same way. If we had a function which merely returned the vnc connection info, I would agree with you that it shouldn't exit. We should do that in 4.2. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |