[Xen-devel] Re: [PATCH,v2]: add libxl python binding

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Sat, 2010-09-11 at 12:27 +0100, Ian Campbell wrote:
> > Anyway, I don't think this stops us getting the code in the tree cos
> > such things can be done in a future patch.
> 
> Agreed.
> 
> Two things though, firstly the patch to Makefile didn't apply for me in
> any version you've sent because tabs have become spaces. Might be an
> issue on my end though.

Hmm, not sure what the culprit is but it's happened to me before, could
be evolution or could be xclip... I should probably hg mail more often
but find it a bit cumbersome tbh. Wierd because the ocaml stuff is tabs
and I assume that worked fine. It may even be vim come to think of it.

> Secondly: 
> xen/lowlevel/xl/xl.c: In function 'fixed_bytearray_set':
> xen/lowlevel/xl/xl.c:164: error: implicit declaration of function 
> 'PyByteArray_Check'
> xen/lowlevel/xl/xl.c:165: error: implicit declaration of function 
> 'PyByteArray_Size'
> xen/lowlevel/xl/xl.c:166: error: implicit declaration of function 
> 'PyByteArray_AsString'
> xen/lowlevel/xl/xl.c:166: error: assignment makes pointer from integer 
> without a cast
> xen/lowlevel/xl/xl.c: In function 'fixed_bytearray_get':
> xen/lowlevel/xl/xl.c:195: error: implicit declaration of function 
> 'PyByteArray_FromStringAndSize'
> xen/lowlevel/xl/xl.c:195: error: return makes pointer from integer without a 
> cast
> error: command 'gcc' failed with exit status 1
> 
> This is with Python 2.5 (default on Debian Lenny so, unfortunately,
> still worth supporting). I guess PyByteArray is new in >2.5? I don't see
> a cunning way around it other than making MAC and UUID first class
> objects instead of wrappers around byte array -- does that make the
> syntax in the user icky?

Well, a binary string will work just as well, making these a first class
object just means adding a parse and unparse method which will be doing
the same thing anyway. I'm pretty sure there'll be a define to check
availability.

> Oh, and I think you want to add the new generated files to .hgignore.

Ah yes, of course


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel