Re: [Xen-devel] [PATCH] xenoprof: Cleanup

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] xenoprof: Cleanup"):
> The declaration of ibs_caps also exists in xen/include/asm-x86/xenoprof.h.
...
> -/* AMD IBS support */
> -extern u32 ibs_caps;

But, in xen/common/xenoprof.c, surely this should be a definition and
not a declaration.  So more correct would be

 -extern u32 ibs_caps;
 +u32 ibs_caps;

but that would conflict with the #define in
xen/include/asm-ia64/xenoprof.h.  So I'm not sure this fix is complete.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel