Re: [Xen-devel] [PATCH 3 of 3] Centralize parsing of PCI BDF's in xl

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Thu, 2010-07-29 at 18:54 +0100, Ian Jackson wrote:
> Gianni Tedesco writes ("Re: [Xen-devel] [PATCH 3 of 3] Centralize parsing of 
> PCI BDF's in xl"):
> > -        printf("\t\t\t(pci dev "PCI_BDF_VDEVFN")\n",
> > +        printf("\t\t\t(pci dev %04x:%02x:%02x.%01x@%02x)\n",
> 
> I like this whole patch apart from this one line :-).  Perhaps
> PCI_BDF_VDEVFN should be LIBXL_PCI_BDF_VDEVFN and be exported in
> libxl.h ?
> 
> Ian.

Actually thinking about this the format is confusing anyway since the
actual notation would be:

printf("%04x:%02x:%02x.%01x=%01x@%02x", domain, bus, dev, func, vdevfn & 0x7, 
vdevfn >> 3);

Whatever you do with it shall be getting cleaned up anyway in my
forthcoming patch-series which actually parses and implements virtual
slots and multi-function devices with function remapping.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel