Re: [Xen-devel] [PATCH 3 of 3] Centralize parsing of PCI BDF's in xl

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Thu, 2010-07-29 at 18:54 +0100, Ian Jackson wrote:
> Gianni Tedesco writes ("Re: [Xen-devel] [PATCH 3 of 3] Centralize parsing of 
> PCI BDF's in xl"):
> > -        printf("\t\t\t(pci dev "PCI_BDF_VDEVFN")\n",
> > +        printf("\t\t\t(pci dev %04x:%02x:%02x.%01x@%02x)\n",
> 
> I like this whole patch apart from this one line :-).  Perhaps
> PCI_BDF_VDEVFN should be LIBXL_PCI_BDF_VDEVFN and be exported in
> libxl.h ?
> 
> Ian.

Yeah makes sense, although I am not so keen on exporting bits of format
strings because it smells too much like policy. Perhaps xl could do it's
own macro for that.

It's your call.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel