Re: [Xen-devel] [PATCH 2 of 9] libxl: return libxl_dominfo from libxl_event_get_domain_death_info

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 26 Jul 2010, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 2 of 9] libxl: return 
> libxl_dominfo from libxl_event_get_domain_death_info"):
> > enum alone would OK, but most header files contains other stuff as well,
> > so including features.h would be fine but including platform.h would not.
> > In order to have a clear policy we should just say that including Xen
> > header files should be avoided.
> 
> I don't think there is any difficulty with libxl callers #including
> Xen public header files, no matter that those Xen header files have
> lots of other stuff in that is not relevant to them.
> 
> It's not as if #including the Xen public headers exposes functions for
> making hypercalls, or indeed any functions or objects at all.
> 
 
No, but they include the shared_info page struct, the start_info page
struct and hypercall numbers and arguments, that is as close
as you can get.

I still think that callers shouldn't be required to include xen header
files.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel