Re: [Xen-devel] [PATCH 2 of 9] libxl: return libxl_dominfo from libxl_event_get_domain_death_info

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 26 Jul 2010, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 2 of 9] libxl: return libxl_dominfo 
> from libxl_event_get_domain_death_info"):
> > libxl: return libxl_dominfo from libxl_event_get_domain_death_info
> > Removes a libxc data type from the libxl interface.
> 
> I don't think this is the right approach, mainly because shutdown
> reasons aren't a libxc datatype, but a Xen one.  My view is that libxl
> should hide libxc, but that it is allowed to expose Xen.
> 
> So libxl callers are allowed to #include xen/include/public/sched.h.
> 

if libxl should hide libxc then allowing clients to include a Xen header
is an even worse layering violation.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel