RE: [Xen-devel][PATCH 02/02] VMX: Add HVM RDTSCP support

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> 11.12.09 17:22 >>>
>       Here is the updated one, I add the BUILD_BUG_ON() and some comments. 

I still don't think that's what we want: It's not a bug if MSR_INDEX_SIZE
is not 3. A BUILD_BUG_ON() should check things that ought to be
guaranteed, but shouldn't require adjustment each time some table
gets expanded/shrunk. What you want to minimally check is
ARRAY_SIZE(msr_index) == VMX_INDEX_MSR_TSC_AUX &&
VMX_INDEX_MSR_TSC_AUX == VMX_MSR_COUNT - 1.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel